Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PBNTR-771] Advanced Table Rails Refactor and Multi Column Headers #4052

Merged
merged 32 commits into from
Jan 3, 2025
Merged

[PBNTR-771] Advanced Table Rails Refactor and Multi Column Headers #4052

merged 32 commits into from
Jan 3, 2025

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Dec 23, 2024 •
edited
Loading

Runway Story

  • ✅ Refactor AdvancedTable for Rails to use html table instead of divs
  • ✅ Redo toggling logic to account change
  • ✅ children rows to retain expanded state when any item is toggled
  • ✅ toggle all button to have access to expandedRows state
  • ✅ Add logic for multiple column headers for Rails side of Advanced Table
  • ✅ Add logic for multiple levels of columns, not just 2
  • ✅ Styling for multiple headers variant

Screenshot 2024-12-31 at 4 01 10 PM

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) minor Semver Target labels Dec 23, 2024
@nidaqg nidaqg self-assigned this Dec 23, 2024
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-771

@nidaqg nidaqg added the milano 20 MAX - Deploy this PR to a review environment via Milano label Dec 26, 2024
@nidaqg nidaqg marked this pull request as ready for review December 31, 2024 20:23
@nidaqg nidaqg requested a review from a team as a code owner December 31, 2024 20:23
@nidaqg nidaqg changed the title [PBNTR-771] Multi Column Headers for Advanced Table-RAILS [PBNTR-771] Advanced Table Rails Refactor and Multi Column Headers Dec 31, 2024
ElisaShapiro
ElisaShapiro previously approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@ElisaShapiro ElisaShapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great and sort icons are back on enable sorting doc ex!

@nidaqg nidaqg added the Product Approved pending technical review, OK to merge to master label Jan 3, 2025
@nidaqg nidaqg merged commit cef313f into master Jan 3, 2025
7 checks passed
@nidaqg nidaqg deleted the PBNTR-771 branch January 3, 2025 20:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

You merged this pr to master branch:
- Ruby Gem: 14.11.0.pre.rc.10
- NPM: 14.11.0-rc.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickamantia nickamantia nickamantia approved these changes

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@ElisaShapiro ElisaShapiro ElisaShapiro left review comments

Assignees

@nidaqg nidaqg

Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target Product Approved pending technical review, OK to merge to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nidaqg @jasperfurniss @ElisaShapiro @nickamantia